Revert "Solve Kombu filesystem transport not thread safe" #1595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1593
Sorry, the PR created by me works even worse than previous on our program. It only solved part of the problem and introduce a new one. I'll create a new PR later.
The previous problem comes from:
_queue_bind
We first read the table and then add a new line to it. We do add a lock during both progress but released it too quickly and the file might change between these two progress.
2. in
_get
and_purge
we modified the data but didn't add a lock to them.signal
only works in the main thread.Actually, I didn't expect it to be merged so quickly. Next time I'll add draft sign to any PR that hadn'd been carefully tested.
I'll create a new PR next Monday.